mirror of
https://github.com/PR0M3TH3AN/bitvid.git
synced 2026-10-27 07:52:24 +00:00
fix(feed): keep audio-only notes (podcasts/music) out of the video grid
A podcast/music note published as a native kind-30078 (content url = an .ogg/
.mp3 audio file, imeta `m audio/*`) was accepted by convertEventToVideo (it has
a url) and rendered as a broken <video> — black frame + audio on Chrome/FF,
MEDIA_ERR_SRC_NOT_SUPPORTED on Safari/iOS — since bitvid has no <audio> player.
The existing audio guard only covered the NIP-71 ingest path, not native events.
convertEventToVideo now marks such notes invalid ("audio-only source (no video)")
so every ingestion path that already drops invalid filters them: main feed buffer,
author/channel batch fetch, and local ingest. Audio-only = no magnet AND no
`imeta m video/*` AND (an `imeta m audio/*` variant OR an unambiguous audio URL
.mp3/.m4a/.aac/.wav/.flac/.opus/.oga/.weba). `.ogg` alone is NOT filtered
(ambiguous → video/ogg); only when imeta says audio. A video imeta variant wins.
Direct open-by-nevent is intentionally unaffected — an explicit link still loads.
Near-term half of TODO #60 (the future dedicated Audio tab remains open).
Tests: tests/video-schema-and-conversion.test.mjs (+5, 8/8). Lint + build green.
Co-Authored-By: Claude Opus 4.8 <[email protected]>
This commit is contained in:
1 parent
1a4e53bdb1
commit
17b48cbfd7
3 files changed
+173
-7
No files matched your search
@@ -76,3 +76,115 @@ test("convertEventToVideo normalizes nsfw and kids booleans", () => {
|
||||
assert.equal(defaultParsed.isNsfw, false);
|
||||
assert.equal(defaultParsed.isForKids, false);
|
||||
});
|
||||
|
||||
// TODO #60: audio-only notes (podcasts/music published as native kind-30078)
|
||||
// must not leak into the video feed — bitvid has no <audio> player, so they
|
||||
// render as a broken <video>. convertEventToVideo marks them invalid so every
|
||||
// feed/grid ingestion path (which already drops invalid) filters them out.
|
||||
|
||||
test("audio-only event with imeta m audio/* is filtered as invalid", () => {
|
||||
const podcast = {
|
||||
id: "evt-audio-imeta",
|
||||
content: JSON.stringify({
|
||||
version: 3,
|
||||
title: "Nostr Compass Podcast #20",
|
||||
url: "https://relay.example/episode.ogg",
|
||||
videoRootId: "root-podcast",
|
||||
}),
|
||||
tags: [
|
||||
[
|
||||
"imeta",
|
||||
"url https://relay.example/episode.ogg",
|
||||
"m audio/ogg",
|
||||
"duration 5254",
|
||||
],
|
||||
],
|
||||
};
|
||||
|
||||
const parsed = convertEventToVideo(podcast);
|
||||
assert.equal(parsed.invalid, true, "audio-only note should be invalid");
|
||||
assert.match(parsed.reason, /audio-only/);
|
||||
});
|
||||
|
||||
test("audio-only url extension (mp3) with no imeta is filtered", () => {
|
||||
const track = {
|
||||
id: "evt-audio-ext",
|
||||
content: JSON.stringify({
|
||||
version: 3,
|
||||
title: "A song",
|
||||
url: "https://cdn.example/track.mp3?v=2",
|
||||
videoRootId: "root-track",
|
||||
}),
|
||||
tags: [],
|
||||
};
|
||||
|
||||
assert.equal(convertEventToVideo(track).invalid, true);
|
||||
});
|
||||
|
||||
test(".ogg url WITHOUT an audio imeta is kept (ambiguous → treated as video)", () => {
|
||||
const ambiguousOgg = {
|
||||
id: "evt-ogg-ambiguous",
|
||||
content: JSON.stringify({
|
||||
version: 3,
|
||||
title: "Theora clip",
|
||||
url: "https://cdn.example/clip.ogg",
|
||||
videoRootId: "root-ogg",
|
||||
}),
|
||||
tags: [],
|
||||
};
|
||||
|
||||
const parsed = convertEventToVideo(ambiguousOgg);
|
||||
assert.equal(parsed.invalid, false, ".ogg alone must not be filtered");
|
||||
assert.equal(parsed.url, "https://cdn.example/clip.ogg");
|
||||
});
|
||||
|
||||
test("a video imeta variant wins even when an audio variant is also present", () => {
|
||||
const mixed = {
|
||||
id: "evt-mixed",
|
||||
content: JSON.stringify({
|
||||
version: 3,
|
||||
title: "Talk with audio alt",
|
||||
url: "https://cdn.example/talk.mp4",
|
||||
videoRootId: "root-mixed",
|
||||
}),
|
||||
tags: [
|
||||
["imeta", "url https://cdn.example/talk.mp4", "m video/mp4"],
|
||||
["imeta", "url https://cdn.example/talk.ogg", "m audio/ogg"],
|
||||
],
|
||||
};
|
||||
|
||||
assert.equal(convertEventToVideo(mixed).invalid, false);
|
||||
});
|
||||
|
||||
test("an audio url paired with a magnet is kept (torrent may be video)", () => {
|
||||
const withMagnet = {
|
||||
id: "evt-audio-magnet",
|
||||
content: JSON.stringify({
|
||||
version: 3,
|
||||
title: "Torrented",
|
||||
url: "https://cdn.example/preview.mp3",
|
||||
magnet: "magnet:?xt=urn:btih:0123456789abcdef0123456789abcdef01234567",
|
||||
videoRootId: "root-magnet",
|
||||
}),
|
||||
tags: [["imeta", "url https://cdn.example/preview.mp3", "m audio/mpeg"]],
|
||||
};
|
||||
|
||||
assert.equal(convertEventToVideo(withMagnet).invalid, false);
|
||||
});
|
||||
|
||||
test("a normal video (mp4) event is unaffected by the audio guard", () => {
|
||||
const video = {
|
||||
id: "evt-video",
|
||||
content: JSON.stringify({
|
||||
version: 3,
|
||||
title: "Real video",
|
||||
url: "https://cdn.example/real.mp4",
|
||||
videoRootId: "root-video",
|
||||
}),
|
||||
tags: [["imeta", "url https://cdn.example/real.mp4", "m video/mp4"]],
|
||||
};
|
||||
|
||||
const parsed = convertEventToVideo(video);
|
||||
assert.equal(parsed.invalid, false);
|
||||
assert.equal(parsed.url, "https://cdn.example/real.mp4");
|
||||
});
|
||||
Reference in new issue
Block a user