thePR0M3TH3AN/bitvid
1
0 Fork 0
mirror of https://github.com/PR0M3TH3AN/bitvid.git synced 2026-11-04 03:42:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui): profile modal controller instantiation order

Browse Source 
- Moved controller instantiation (DM, Relay, Hashtag) to after services setup in `ProfileModalController.js`.
- Fixed `ProfileHashtagController` usage of uninitialized services.
- Updated `profile-modal-controller.test.mjs` mock to include `uiReady/dataReady` flags and use correct service access pattern.
- Resolved CI failures in `profile-modal-controller.test.mjs`.

Co-authored-by: PR0M3TH3AN <[email protected]>
This commit is contained in:
google-labs-jules[bot]andPR0M3TH3AN committed 2026-02-13 03:50:42 +00:00
1 parent f8b8bae2e8
commit 4059d52847
2 files changed
+12 -10
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

js/ui/profileModalController.js
+9 -9
View File
@@ -96,11 +96,6 @@ export class ProfileModalController {
this.showStatus = showStatus;
this.designSystem = normalizeDesignSystemContext(designSystem);
this.dmController = new ProfileDirectMessageController(this);
this.relayController = new ProfileRelayController(this);
this.hashtagController = new ProfileHashtagController(this);
this.hashtagController.initialize();
const resolvedMaxWalletDefaultZap =
typeof providedConstants.MAX_WALLET_DEFAULT_ZAP === "number" &&
Number.isFinite(providedConstants.MAX_WALLET_DEFAULT_ZAP)
@@ -168,8 +163,6 @@ export class ProfileModalController {
this.adminSuperNpub = resolvedAdminSuperNpub;
this.adminDmImageUrl = resolvedAdminDmImageUrl;
this.bitvidWebsiteUrl = resolvedbitvidWebsiteUrl;
this.dmController.enableNip17RelayWarning = resolvedEnableNip17RelayWarning;
this.dmController.hasShownRelayWarning = false;
this.internalState = {
savedProfiles: [],
@@ -183,11 +176,18 @@ export class ProfileModalController {
dmRelayHints: new Map(),
};
this.dmController.dmMobileView = "list";
this.services = buildServicesContract(services, this.internalState);
this.state = buildStateContract(state, this.internalState);
this.dmController = new ProfileDirectMessageController(this);
this.relayController = new ProfileRelayController(this);
this.hashtagController = new ProfileHashtagController(this);
this.hashtagController.initialize();
this.dmController.enableNip17RelayWarning = resolvedEnableNip17RelayWarning;
this.dmController.hasShownRelayWarning = false;
this.dmController.dmMobileView = "list";
this.normalizeHexPubkey = this.services.normalizeHexPubkey;
this.safeEncodeNpub = this.services.safeEncodeNpub;
this.safeDecodeNpub = this.services.safeDecodeNpub;