Merge pull request #2005 from PR0M3TH3AN/chore/triage-todos-2139580575813254887

Triage TODOs and report issues
This commit is contained in:
thePR0M3TH3AN authored and GitHub committed 2026-01-31 13:47:32 -05:00
commit 5694e940f0
2 files changed
+25 -8

No files matched your search

+25
View File
@@ -0,0 +1,25 @@
# todo: Investigate why visibility check fails in fixture environment
Found TODOs in `tests/visual/moderation.spec.ts` related to Playwright test failures in headless mode.
## Context
Several tests in `tests/visual/moderation.spec.ts` have commented-out assertions and interactions due to visibility checks failing or clicks timing out when running in the fixture environment (headless).
## TODOs
- `// TODO: Investigate why visibility check fails in fixture environment (headless)`
- `// TODO: Investigate why click times out in fixture environment (headless)`
- `// TODO: Investigate visibility check failure`
- `// TODO: Investigate click timeout failure`
## Code Excerpt
```typescript
// TODO: Investigate why visibility check fails in fixture environment (headless)
// await expect(showAnywayButton).toBeVisible();
await expect(restoreButtonQuery).toHaveCount(0);
// TODO: Investigate why click times out in fixture environment (headless)
// await showAnywayButton.click({ force: true });
```
## Suggested Next Step
Investigate the `tests/visual/moderation.spec.ts` execution in headless mode. It might be related to rendering timing, fixture loading state, or specific CSS properties affecting visibility in the headless renderer.
-8
View File
@@ -1,9 +1 @@
issues/todo-moderation-tests.md:1:# TODO: Investigate flaky visual regression tests
issues/todo-moderation-tests.md:10:**TODOs:**
js/ui/profileModalController.js:204: "Formats npub strings for display using the canonical short representation (npubXXXX…XXXX).",
tests/visual/moderation.spec.ts:89: // TODO: Investigate why visibility check fails in fixture environment (headless)
tests/visual/moderation.spec.ts:93: // TODO: Investigate why click times out in fixture environment (headless)
tests/visual/moderation.spec.ts:166: // TODO: Investigate visibility check failure
tests/visual/moderation.spec.ts:170: // TODO: Investigate click timeout failure
tests/visual/moderation.spec.ts:219: // TODO: Investigate visibility check failure
tests/visual/moderation.spec.ts:223: // TODO: Investigate click timeout failure