mirror of
https://github.com/PR0M3TH3AN/bitvid.git
synced 2026-10-27 07:52:24 +00:00
chore: add test audit workflow and improve AuthService coverage
Co-authored-by: PR0M3TH3AN <[email protected]>
This commit is contained in:
google-labs-jules[bot]andPR0M3TH3AN committed
1 parent
68b583fb9b
commit
588793dba7
11 files changed
+41497
-27
No files matched your search
+16
-10
@@ -1,14 +1,20 @@
|
||||
# Context: bitvid-perf-agent
|
||||
# Test Audit Context
|
||||
|
||||
## Mission
|
||||
Daily, measurable improvement of app responsiveness and documentation accuracy.
|
||||
## Purpose
|
||||
This audit aims to verify the integrity and effectiveness of the bitvid test suite. The goal is to ensure tests actually test the behaviors they claim to, find fragile or missing tests, and propose small, high-confidence fixes to raise test quality and coverage.
|
||||
|
||||
## Scope
|
||||
- **Repo:** `PR0M3TH3AN/bitvid` (unstable)
|
||||
- **Focus:**
|
||||
- P0: Fix unbounded concurrency in background tasks.
|
||||
- Docs: Ensure `/content` upload guides match runtime behavior.
|
||||
- **Focus Areas**: UX- and security-critical code paths including:
|
||||
- Login/Auth (`js/services/authService.js`)
|
||||
- Relay Management (`js/relayManager.js`)
|
||||
- Decryption (`js/nostr/dmDecryptWorker.js`)
|
||||
- Watch History (`js/nostr/watchHistory.js`)
|
||||
- Moderation (`js/userBlocks.js`)
|
||||
- **Exclusions**: Non-critical UI components, deprecated code.
|
||||
|
||||
## Current Task (Run 1)
|
||||
- Fix unbounded concurrency in `js/nostr/commentEvents.js`.
|
||||
- Fix outdated CORS port in `content/docs/guides/upload-content.md`.
|
||||
## Definition of Done
|
||||
- A daily audit report (`test-audit-report-YYYY-MM-DD.md`) is generated.
|
||||
- Failing and flaky tests are identified.
|
||||
- Coverage gaps for critical files are mapped.
|
||||
- At least one P0 test problem is fixed or tracked as an actionable issue.
|
||||
- All artifacts are committed.
|
||||
+1
-9
@@ -1,9 +1 @@
|
||||
# Decisions Log
|
||||
|
||||
## Performance
|
||||
- **2026-02-xx:** Use `pMap` with `RELAY_BACKGROUND_CONCURRENCY` (3) for comment publishing and fetching.
|
||||
- **Rationale:** `Promise.all` floods the network when users have many relays. Bounding concurrency prevents resource exhaustion.
|
||||
|
||||
## Documentation
|
||||
- **2026-02-xx:** Standardize local dev port to 3000 in docs.
|
||||
- **Rationale:** Matches `npm start` default and `README.md`.
|
||||
# Decisions
|
||||
+35659
-3
File diff suppressed because it is too large.
Load diff
@@ -1,5 +1 @@
|
||||
# TODO
|
||||
|
||||
- [ ] Fix unbounded concurrency in `js/nostr/commentEvents.js` using `pMap`.
|
||||
- [ ] Update CORS port in `content/docs/guides/upload-content.md` to 3000.
|
||||
- [ ] Run `npm run lint` and `npm run test:unit` to verify.
|
||||
# To Do
|
||||
@@ -0,0 +1,34 @@
|
||||
# Test Audit Report (2025-02-18)
|
||||
|
||||
## Summary
|
||||
The test suite is functional but slow (~6m+ if run fully with retry). Overall line coverage is ~42%, with critical gaps in `authService.js` (10%) and `playbackCoordinator.js` (9%). Static analysis reveals widespread usage of `setTimeout` in tests, which contributes to potential flakiness and slowness.
|
||||
|
||||
## Test Run
|
||||
- **Environment**: Node.js v22 (experimental-test-coverage enabled)
|
||||
- **Result**: 361 tests passed, 0 failed.
|
||||
- **Flakiness**: Unable to fully assess due to timeout (suite > 400s), but timeouts in test code indicate risk.
|
||||
|
||||
## Coverage Gaps (Critical Files)
|
||||
| File | Coverage (Line) | Criticality |
|
||||
| :--- | :--- | :--- |
|
||||
| `js/services/authService.js` | 10.16% | **P0** (Login/Security) |
|
||||
| `js/app/playbackCoordinator.js` | 9.70% | **P0** (Core Feature) |
|
||||
| `js/userBlocks.js` | 18.92% | **P1** (Moderation) |
|
||||
| `js/relayManager.js` | 49.94% | **P1** (Network) |
|
||||
| `js/nostr/watchHistory.js` | 46.24% | **P1** (User Data) |
|
||||
| `js/nostr/dmDecryptWorkerClient.js`| 44.09% | **P1** (Privacy) |
|
||||
|
||||
## Findings & Smells
|
||||
1. **Low Coverage in Auth**: `authService.js` is barely tested. It handles login, key management, and profile hydration.
|
||||
2. **Timeouts in Tests**: Found 19 instances of `setTimeout` in tests. `tests/nostr/dm-direct-message-flow.test.mjs` uses `setTimeout(r, intervalMs)` and `setTimeout(resolve, 100)` to wait for events, which is fragile.
|
||||
3. **Console Logs**: 20+ instances of `console.log` in test files.
|
||||
4. **Slow Tests**: The suite takes too long to run repeatedly for flakiness checks.
|
||||
|
||||
## Recommendations
|
||||
1. **Fix P0 Coverage**: Add unit tests for `authService.js` (login flows, error handling).
|
||||
2. **Refactor Timeouts**: Replace `setTimeout` with `waitFor` helpers or event listeners in `dm-direct-message-flow.test.mjs`.
|
||||
3. **Cleanup**: Remove `console.log` from tests.
|
||||
|
||||
## Remediation Plan
|
||||
- **Action**: Create a PR to add tests for `js/services/authService.js`.
|
||||
- **Target**: Increase coverage for `authService` to > 30% by testing the public `login` and `logout` methods.
|
||||
@@ -0,0 +1,71 @@
|
||||
tests/subscriptions-feed.test.mjs:console.log("subscriptions-feed tests passed");
|
||||
tests/webtorrent-regression.test.mjs: console.log("Failed result:", result);
|
||||
tests/nostr-publish-rejection.test.mjs: console.log("nostr publish rejection tests passed");
|
||||
tests/zap-shared-state.test.mjs:console.log("zap-shared-state tests passed");
|
||||
tests/view-counter.test.mjs:console.log("View counter tests completed successfully.");
|
||||
tests/watch-history-feed.test.mjs:console.log("watch-history-feed.test.mjs completed successfully.");
|
||||
tests/e2e/repro_issue.spec.ts: console.log('PAGE ERROR:', err.message);
|
||||
tests/e2e/repro_issue.spec.ts: console.log('Timeout waiting for status change. Current status:', await page.locator('#embedStatus').textContent());
|
||||
tests/e2e/repro_issue.spec.ts: console.log('No TypeError found.');
|
||||
tests/e2e/repro_issue.spec.ts: console.log('Console output:', consoleMessages.join('\n'));
|
||||
tests/e2e/video-modal-share-bug.spec.ts: console.log(\`setGlobalModalState: \${name} = \${isOpen}\`);
|
||||
tests/app-batch-fetch-profiles.test.mjs: // console.log("pool.list called with relays:", relays);
|
||||
tests/app-batch-fetch-profiles.test.mjs: // console.log("poolListCalls.length:", poolListCalls.length);
|
||||
tests/app-batch-fetch-profiles.test.mjs: // console.log("nostrClient.relays:", nostrClient.relays);
|
||||
tests/watchHistory/watch-history-telemetry.test.mjs:console.log("watch-history-telemetry tests passed");
|
||||
tests/feed-engine.test.mjs:console.log("All feed engine tests passed");
|
||||
tests/utils/domUtils.test.mjs: inlineScript.textContent = "console.log('hello')";
|
||||
tests/utils/domUtils.test.mjs: assert.equal(container.querySelector("script").textContent, "console.log('hello')");
|
||||
tests/nostr-rebroadcast-guard.test.mjs:console.log("nostr rebroadcast guard tests passed");
|
||||
tests/nostr-boost-actions.test.mjs:console.log("nostr boost action tests passed");
|
||||
tests/check_resize_observer.mjs: console.log("globalThis.ResizeObserver:", typeof globalThis.ResizeObserver);
|
||||
tests/nostr-ephemeral-dm-tester.html: console.log(`[${type.toUpperCase()}] ${msg}`);
|
||||
tests/zap-split.test.mjs:console.log("zap-split tests passed");
|
||||
tests/watch-history.test.mjs: console.log("Running normalizeActorKey short-circuit test...");
|
||||
tests/watch-history.test.mjs: console.log("Running normalizeActorKey manual fallback test...");
|
||||
tests/watch-history.test.mjs: console.log("Running watch history snapshot inflight queue retention test...");
|
||||
tests/watch-history.test.mjs: console.log("Running watch history snapshot merge test...");
|
||||
tests/watch-history.test.mjs: console.log("Running watch history card playback metadata test...");
|
||||
tests/watch-history.test.mjs: console.log("Running watch history stale cache refresh test...");
|
||||
tests/watch-history.test.mjs: console.log("Running watch history local fallback test...");
|
||||
tests/watch-history.test.mjs: console.log("Running watch history renderer feed registration fallback test...");
|
||||
tests/watch-history.test.mjs: console.log("Running watch history logged-in sync override test...");
|
||||
tests/watch-history.test.mjs: console.log("Running watch history app login fallback test...");
|
||||
tests/watch-history.test.mjs: console.log("Running watch history feed hydration test...");
|
||||
tests/watch-history.test.mjs:console.log("watch-history.test.mjs completed successfully");
|
||||
tests/discussion-count-service.test.mjs:console.log("discussion-count-service tests passed");
|
||||
tests/nostr-view-events.test.mjs:console.log("nostr view events tests passed");
|
||||
tests/admin-list-store.test.mjs:console.log("admin-list-store tests passed");
|
||||
tests/nostr-count-fallback.test.mjs:console.log("nostr COUNT fallback tests completed successfully.");
|
||||
tests/visual/moderation.spec.ts: page.on('console', msg => console.log('PAGE LOG:', msg.text()));
|
||||
tests/visual/moderation.spec.ts: page.on('pageerror', err => console.log('PAGE ERROR:', err.message));
|
||||
tests/benchmark-explore-data.spec.mjs: console.log(`[Benchmark] buildWatchHistoryTagCounts: ${result.countsTime.toFixed(2)}ms`);
|
||||
tests/benchmark-explore-data.spec.mjs: console.log(`[Benchmark] buildTagIdf: ${result.idfTime.toFixed(2)}ms`);
|
||||
tests/benchmark-explore-data.spec.mjs: console.log(`[Benchmark] Counts Size: ${result.countsSize}`);
|
||||
tests/benchmark-explore-data.spec.mjs: console.log(`[Benchmark] IDF Size: ${result.idfSize}`);
|
||||
tests/nostr-view-event-bindings.test.mjs:console.log("nostr-view-event-bindings tests passed");
|
||||
tests/ui/components/debug_hashtag_strip_helper.test.mjs: console.log(`DEBUG: window.addEventListener('${event}') called`);
|
||||
tests/ui/components/debug_hashtag_strip_helper.test.mjs: console.log("Global ResizeObserver type:", typeof globalThis.ResizeObserver);
|
||||
tests/ui/components/debug_hashtag_strip_helper.test.mjs: console.log("Helper window ResizeObserver:", typeof helper.window.ResizeObserver);
|
||||
tests/ui/uploadModal-reset.test.mjs: global.alert = (msg) => { console.log("ALERT CALLED:", msg); };
|
||||
tests/ui/profileModalController-addProfile.test.mjs: showSuccess: (msg) => { console.log("Success:", msg); },
|
||||
tests/performance/resolvePostedAt.test.mjs: console.log(`pool.list calls: ${listCalls}`);
|
||||
tests/performance/resolvePostedAt.test.mjs: console.log(`pool.get calls: ${getCalls}`);
|
||||
tests/embed_playback_check.spec.mjs: console.log('Starting reproduction script...');
|
||||
tests/embed_playback_check.spec.mjs: console.log(`Starting local relay on port ${relayPort}...`);
|
||||
tests/embed_playback_check.spec.mjs: console.log(`Starting web server on port ${serverPort}...`);
|
||||
tests/embed_playback_check.spec.mjs: console.log('Launching headless browser...');
|
||||
tests/embed_playback_check.spec.mjs: console.log(`[BROWSER CONSOLE] ${msg.type()}: ${msg.text()}`);
|
||||
tests/embed_playback_check.spec.mjs: console.log('!!! CAUGHT EXPECTED ERROR IN CONSOLE !!!');
|
||||
tests/embed_playback_check.spec.mjs: console.log(`[BROWSER PAGEERROR] ${err.message}`);
|
||||
tests/embed_playback_check.spec.mjs: console.log('!!! CAUGHT EXPECTED ERROR IN PAGEERROR !!!');
|
||||
tests/embed_playback_check.spec.mjs: console.log(`Navigating to ${baseUrl} to setup...`);
|
||||
tests/embed_playback_check.spec.mjs: console.log(`Published video event: ${eventId}`);
|
||||
tests/embed_playback_check.spec.mjs: console.log(`Navigating to embed: ${embedUrl}`);
|
||||
tests/embed_playback_check.spec.mjs: console.log(`Response status: ${response.status()} ${response.statusText()}`);
|
||||
tests/embed_playback_check.spec.mjs: console.log(`Response url: ${response.url()}`);
|
||||
tests/embed_playback_check.spec.mjs: console.log(`Current Location: ${locationHref}`);
|
||||
tests/embed_playback_check.spec.mjs: console.log('Waiting for error...');
|
||||
tests/embed_playback_check.spec.mjs: console.log(`Current Embed Status: "${statusText}"`);
|
||||
tests/embed_playback_check.spec.mjs: console.log('SUCCESS: TypeError fixed (not found).');
|
||||
tests/nostr-delete-flow.test.mjs:console.log("nostr delete flow tests passed");
|
||||
File diff suppressed because it is too large.
Load diff
@@ -0,0 +1,4 @@
|
||||
tests/e2e/agent-testability.spec.ts: const resp = await fetch(`${httpUrl}/events`);
|
||||
tests/e2e/agent-testability.spec.ts: const resp = await fetch(`${httpUrl}/health`);
|
||||
tests/e2e/helpers/bitvidTestFixture.ts: const resp = await fetch(`${httpUrl}/seed`, {
|
||||
tests/e2e/helpers/bitvidTestFixture.ts: const resp = await fetch(`${httpUrl}/events`, { method: "DELETE" });
|
||||
Whitespace-only changes.
@@ -0,0 +1,119 @@
|
||||
tests/video-modal-zap.test.mjs: setTimeout,
|
||||
tests/webtorrent-regression.test.mjs: setTimeout(() => {
|
||||
tests/webtorrent-regression.test.mjs: setTimeout(() => {
|
||||
tests/video-card-source-visibility.test.mjs: window.requestAnimationFrame = (cb) => setTimeout(() => cb(Date.now()), 16);
|
||||
tests/video-card-source-visibility.test.mjs: window.requestAnimationFrame = (cb) => setTimeout(() => cb(Date.now()), 16);
|
||||
tests/nostr-send-direct-message.test.mjs: setTimeout(() => process.exit(0), 100);
|
||||
tests/nostr-send-direct-message.test.mjs: setTimeout(() => handler(), 0);
|
||||
tests/view-counter.test.mjs:const flushPromises = () => new Promise((resolve) => setTimeout(resolve, 0));
|
||||
tests/view-counter.test.mjs: setTimeout(() => handler(), 0);
|
||||
tests/subscriptions-manager.test.mjs: await new Promise((resolve) => setTimeout(resolve, 0));
|
||||
tests/nostr/toolkit.test.mjs: setTimeout(() => {
|
||||
tests/nostr/sign-request-queue.test.mjs:const delay = (ms) => new Promise((resolve) => setTimeout(resolve, ms));
|
||||
tests/nostr/integration-remote-flow.test.mjs: setTimeout(() => handler(), 0);
|
||||
tests/nostr/dm-direct-message-flow.test.mjs: await new Promise((r) => setTimeout(r, intervalMs));
|
||||
tests/nostr/dm-direct-message-flow.test.mjs: await new Promise((resolve) => setTimeout(resolve, 100)); // Still wait to ensure no duplication appears
|
||||
tests/nostr/dmSignalEvents.test.mjs: if (event === 'ok') setTimeout(cb, 0);
|
||||
tests/nostr/client.test.mjs: await new Promise(r => setTimeout(r, 300));
|
||||
tests/nostr/client.test.mjs: if (evt === "eose") setTimeout(handler, 0);
|
||||
tests/nostr/client.test.mjs: if (evt === "eose") setTimeout(handler, 0);
|
||||
tests/nostr/nip07Permissions.test.js: setTimeout(() => {
|
||||
tests/nostr/watchHistory.test.js: setTimeout(handler, 0);
|
||||
tests/nostr/comment-events.test.mjs: await new Promise(resolve => setTimeout(resolve, 0));
|
||||
tests/torrent/toast-service.test.mjs: await new Promise((resolve) => setTimeout(resolve, 250));
|
||||
tests/hashtag-preferences.test.mjs: setTimeout(() => handler(), 0);
|
||||
tests/hashtag-preferences.test.mjs: setTimeout(() => process.exit(0), 100);
|
||||
tests/nostr-private-key-signer.test.mjs: setTimeout(() => process.exit(0), 100);
|
||||
tests/e2e/webseed-playback.spec.ts: test.setTimeout(90000); // Increase timeout for fallback logic
|
||||
tests/nwc-client.test.mjs: setTimeout(() => {
|
||||
tests/nwc-client.test.mjs: setTimeout(() => {
|
||||
tests/watchHistory/watch-history-telemetry.test.mjs: await new Promise((resolve) => setTimeout(resolve, 0));
|
||||
tests/feed-engine.test.mjs: await new Promise((resolve) => setTimeout(resolve, 0));
|
||||
tests/profile-cache.test.mjs: // Wait for async write (runIdle/setTimeout)
|
||||
tests/profile-cache.test.mjs: await new Promise((resolve) => setTimeout(resolve, 20));
|
||||
tests/profile-cache.test.mjs: // Wait for async write (runIdle/setTimeout)
|
||||
tests/profile-cache.test.mjs: await new Promise((resolve) => setTimeout(resolve, 20));
|
||||
tests/dm-normalization.test.mjs: await new Promise((resolve) => setTimeout(resolve, 50));
|
||||
tests/dm-normalization.test.mjs: setTimeout(() => process.exit(0), 100);
|
||||
tests/webtorrent-handlers.test.mjs: setTimeout(() => {
|
||||
tests/webtorrent-handlers.test.mjs: await new Promise(r => setTimeout(r, 20));
|
||||
tests/webtorrent-handlers.test.mjs: await new Promise(r => setTimeout(r, 20));
|
||||
tests/sign-request-queue.test.mjs: await new Promise((resolve) => setTimeout(resolve, 50));
|
||||
tests/sign-request-queue.test.mjs: await new Promise((resolve) => setTimeout(resolve, 50));
|
||||
tests/sign-request-queue.test.mjs: await new Promise((resolve) => setTimeout(resolve, 200));
|
||||
tests/moderation/video-card.test.mjs: window.requestAnimationFrame = (cb) => setTimeout(() => cb(Date.now()), 16);
|
||||
tests/moderation/video-card.test.mjs: window.requestAnimationFrame = (cb) => setTimeout(() => cb(Date.now()), 16);
|
||||
tests/moderation/video-card.test.mjs: await new Promise((resolve) => setTimeout(resolve, 0));
|
||||
tests/moderation/video-card.test.mjs: await new Promise((resolve) => setTimeout(resolve, 0));
|
||||
tests/moderation/video-card.test.mjs: await new Promise((resolve) => setTimeout(resolve, 0));
|
||||
tests/moderation/video-card.test.mjs: await new Promise((resolve) => setTimeout(resolve, 0));
|
||||
tests/moderation/submit-report.test.mjs: setTimeout(() => handler(), 0);
|
||||
tests/modal-accessibility.test.mjs: setTimeout(() => callback(Date.now()), 0);
|
||||
tests/zap-split.test.mjs: setTimeout(() => {
|
||||
tests/profile-modal-controller.test.mjs: await new Promise((resolve) => setTimeout(resolve, 0));
|
||||
tests/profile-modal-controller.test.mjs: await new Promise((resolve) => setTimeout(resolve, 0));
|
||||
tests/profile-modal-controller.test.mjs: await new Promise((resolve) => setTimeout(resolve, 0));
|
||||
tests/auth-service.test.mjs: await new Promise((resolve) => setTimeout(resolve, 10));
|
||||
tests/auth-service.test.mjs: await new Promise((resolve) => setTimeout(resolve, 10));
|
||||
tests/test-helpers/wait-for.mjs: await new Promise((resolve) => setTimeout(resolve, interval));
|
||||
tests/watch-history.test.mjs: setTimeout(() => {
|
||||
tests/watch-history.test.mjs: await new Promise((resolve) => setTimeout(resolve, 0));
|
||||
tests/watch-history.test.mjs: await new Promise((resolve) => setTimeout(resolve, 0));
|
||||
tests/watch-history.test.mjs: await new Promise((resolve) => setTimeout(resolve, 0));
|
||||
tests/watch-history.test.mjs: await new Promise(r => setTimeout(r, 50));
|
||||
tests/user-blocks.test.mjs:await new Promise((resolve) => setTimeout(resolve, 100));
|
||||
tests/user-blocks.test.mjs:await new Promise((resolve) => setTimeout(resolve, 100));
|
||||
tests/nostr-service-access-control.test.mjs: setTimeout(() => process.exit(0), 100);
|
||||
tests/nostr-login-permissions.test.mjs: setTimeout(() => reject(new Error("permission denied")), 300);
|
||||
tests/admin-list-store.test.mjs: setTimeout(fn, delay);
|
||||
tests/admin-list-store.test.mjs:await new Promise((resolve) => setTimeout(resolve, slowRelayDelayMs + 20));
|
||||
tests/visual/overlay-layers.spec.ts: test.setTimeout(120_000);
|
||||
tests/state/cache.test.mjs: await new Promise((resolve) => setTimeout(resolve, 10));
|
||||
tests/nip07-concurrency.test.mjs: await new Promise(resolve => setTimeout(resolve, delay));
|
||||
tests/nip07-concurrency.test.mjs: // Note: Node's setTimeout is not precise, so we use loose bounds
|
||||
tests/nip07-concurrency.test.mjs: await new Promise(resolve => setTimeout(resolve, delay));
|
||||
tests/nostr-nip46-queue.test.mjs: await new Promise(r => setTimeout(r, 10));
|
||||
tests/nostr-nip46-queue.test.mjs: await new Promise(r => setTimeout(r, 50));
|
||||
tests/nostr-nip46-queue.test.mjs: await new Promise(r => setTimeout(r, 100));
|
||||
tests/ui/uploadModal-integration.test.mjs: await new Promise(r => setTimeout(r, 10));
|
||||
tests/ui/components/hashtagStripHelper.test.mjs: // Mock setTimeout if needed
|
||||
tests/ui/components/hashtagStripHelper.test.mjs: win.setTimeout = (callback, delay) => {
|
||||
tests/ui/components/hashtagStripHelper.test.mjs: // JSDOM provides setTimeout by default, remove it if requested
|
||||
tests/ui/components/hashtagStripHelper.test.mjs: // Note: removing setTimeout might break other things, so use with caution
|
||||
tests/ui/components/hashtagStripHelper.test.mjs: // But for testing fallback path where RAF is missing, we usually want setTimeout available.
|
||||
tests/ui/components/hashtagStripHelper.test.mjs: // If we want to test "no RAF, use setTimeout", we remove RAF.
|
||||
tests/ui/components/hashtagStripHelper.test.mjs:test("HashtagStripHelper falls back to window resize with setTimeout when RAF is missing", (t) => {
|
||||
tests/ui/engagement-controller.test.mjs: global.window = { setTimeout: t.mock.fn() };
|
||||
tests/ui/hashtag-strip-helper-bounce.test.mjs: // Mock setTimeout
|
||||
tests/ui/hashtag-strip-helper-bounce.test.mjs: window.setTimeout = (cb, delay) => {
|
||||
tests/ui/hashtag-strip-helper-bounce.test.mjs: window.setTimeout = (cb, delay) => {
|
||||
tests/ui/url-health-controller.test.mjs: await new Promise(resolve => setTimeout(resolve, 100));
|
||||
tests/ui/url-health-controller.test.mjs: setTimeout(handler, 10);
|
||||
tests/ui/url-health-controller.test.mjs: setTimeout(handler, 10);
|
||||
tests/ui/url-health-controller.test.mjs: setTimeout(handler, 0);
|
||||
tests/ui/url-health-controller.test.mjs: await new Promise(resolve => setTimeout(resolve, 50));
|
||||
tests/compliance/nip07_compliance.test.mjs: await new Promise(resolve => setTimeout(resolve, 50));
|
||||
tests/unit/notificationController.test.mjs: setTimeout: mock.fn((cb, ms) => setTimeout(cb, ms)),
|
||||
tests/unit/client-count-resilience.test.mjs: await new Promise(r => setTimeout(r, 100));
|
||||
tests/unit/services/r2Service.storage-config.test.mjs: originalSetTimeout = globalThis.setTimeout;
|
||||
tests/unit/services/r2Service.storage-config.test.mjs: globalThis.setTimeout = (fn) => {
|
||||
tests/unit/services/r2Service.storage-config.test.mjs: globalThis.setTimeout = originalSetTimeout;
|
||||
tests/nostr-signer-race.test.mjs: await new Promise(resolve => setTimeout(resolve, 50));
|
||||
tests/embed_playback_check.spec.mjs: await new Promise(resolve => setTimeout(resolve, 2000));
|
||||
tests/comment-thread-service.test.mjs:const tick = (ms = 0) => new Promise((resolve) => setTimeout(resolve, ms));
|
||||
tests/services/link-preview-service.test.mjs: await new Promise((r) => setTimeout(r, 10));
|
||||
tests/services/playbackService.test.mjs: mock.timers.enable({ apis: ['setTimeout'] });
|
||||
tests/services/trustBootstrap.test.mjs: setTimeout(() => {
|
||||
tests/services/trustBootstrap.test.mjs: await new Promise(resolve => setTimeout(resolve, 300));
|
||||
tests/services/profileMetadataService.test.mjs: await new Promise(r => setTimeout(r, 0));
|
||||
tests/services/playbackService_order.test.mjs: mock.timers.enable({ apis: ['setTimeout'] });
|
||||
tests/services/relay-health-service.test.mjs: setTimeout(() => relay.emit("connect"), 10);
|
||||
tests/services/relay-health-service.test.mjs: const originalSetTimeout = globalThis.setTimeout;
|
||||
tests/services/relay-health-service.test.mjs: // Manually mock setTimeout to capture callback
|
||||
tests/services/relay-health-service.test.mjs: globalThis.setTimeout = (cb, delay) => {
|
||||
tests/services/relay-health-service.test.mjs: throw new Error("setTimeout was not called with 5000ms delay");
|
||||
tests/services/relay-health-service.test.mjs: globalThis.setTimeout = originalSetTimeout;
|
||||
tests/services/playbackService_forcedSource.test.mjs: mock.timers.enable({ apis: ['setTimeout'] });
|
||||
tests/services/playbackService_forcedSource.test.mjs: await new Promise(resolve => setTimeout(resolve, 200));
|
||||
tests/services/playbackService_forcedSource.test.mjs: await new Promise(resolve => setTimeout(resolve, 200));
|
||||
tests/services/playbackService_forcedSource.test.mjs: await new Promise(resolve => setTimeout(resolve, 200));
|
||||
@@ -0,0 +1,208 @@
|
||||
import "./test-helpers/setup-localstorage.mjs";
|
||||
import { test, describe, beforeEach, afterEach, mock } from "node:test";
|
||||
import assert from "node:assert/strict";
|
||||
import AuthService from "../js/services/authService.js";
|
||||
import {
|
||||
getPubkey,
|
||||
setPubkey,
|
||||
getCurrentUserNpub,
|
||||
setCurrentUserNpub,
|
||||
} from "../js/state/appState.js";
|
||||
import {
|
||||
getSavedProfiles,
|
||||
mutateSavedProfiles,
|
||||
getActiveProfilePubkey,
|
||||
setActiveProfilePubkey,
|
||||
} from "../js/state/cache.js";
|
||||
|
||||
// Mock dependencies
|
||||
const mockNostrClient = {
|
||||
pubkey: null,
|
||||
logout: mock.fn(),
|
||||
pool: { list: mock.fn(async () => []) },
|
||||
relays: [],
|
||||
handleEvent: mock.fn(),
|
||||
};
|
||||
|
||||
const mockUserBlocks = {
|
||||
loadBlocks: mock.fn(async () => true),
|
||||
reset: mock.fn(),
|
||||
};
|
||||
|
||||
const mockRelayManager = {
|
||||
loadRelayList: mock.fn(async () => true),
|
||||
reset: mock.fn(),
|
||||
};
|
||||
|
||||
const mockAccessControl = {
|
||||
isLockdownActive: mock.fn(() => false),
|
||||
isAdminEditor: mock.fn(() => false),
|
||||
canAccess: mock.fn(() => true),
|
||||
isBlacklisted: mock.fn(() => false),
|
||||
};
|
||||
|
||||
const mockLogger = mock.fn();
|
||||
|
||||
const mockAuthProvider = {
|
||||
login: mock.fn(async () => ({ pubkey: "0000000000000000000000000000000000000000000000000000000000000001", authType: "nip07" })),
|
||||
};
|
||||
|
||||
const mockGetAuthProvider = mock.fn((id) => mockAuthProvider);
|
||||
|
||||
describe("AuthService Coverage", () => {
|
||||
let authService;
|
||||
|
||||
beforeEach(() => {
|
||||
// Reset global state
|
||||
setPubkey(null);
|
||||
setCurrentUserNpub(null);
|
||||
setActiveProfilePubkey(null, { persist: false });
|
||||
mutateSavedProfiles(() => [], { persist: false, persistActive: false });
|
||||
|
||||
// Reset mocks
|
||||
mockNostrClient.logout.mock.resetCalls();
|
||||
mockUserBlocks.loadBlocks.mock.resetCalls();
|
||||
mockUserBlocks.reset.mock.resetCalls();
|
||||
mockRelayManager.loadRelayList.mock.resetCalls();
|
||||
mockRelayManager.reset.mock.resetCalls();
|
||||
mockAccessControl.isLockdownActive.mock.resetCalls();
|
||||
mockAuthProvider.login.mock.resetCalls();
|
||||
|
||||
authService = new AuthService({
|
||||
nostrClient: mockNostrClient,
|
||||
userBlocks: mockUserBlocks,
|
||||
relayManager: mockRelayManager,
|
||||
logger: mockLogger,
|
||||
accessControl: mockAccessControl,
|
||||
getAuthProvider: mockGetAuthProvider,
|
||||
});
|
||||
});
|
||||
|
||||
describe("login", () => {
|
||||
test("successfully logs in with valid pubkey", async () => {
|
||||
const pubkey = "0000000000000000000000000000000000000000000000000000000000000001";
|
||||
const result = await authService.login(pubkey);
|
||||
|
||||
assert.equal(getPubkey(), pubkey);
|
||||
assert.equal(getActiveProfilePubkey(), pubkey);
|
||||
assert.equal(result.pubkey, pubkey);
|
||||
|
||||
const saved = getSavedProfiles();
|
||||
assert.equal(saved.length, 1);
|
||||
assert.equal(saved[0].pubkey, pubkey);
|
||||
});
|
||||
|
||||
test("updates global state and calls post-login hooks", async () => {
|
||||
const pubkey = "0000000000000000000000000000000000000000000000000000000000000002";
|
||||
await authService.login(pubkey);
|
||||
|
||||
assert.strictEqual(mockRelayManager.loadRelayList.mock.callCount(), 1);
|
||||
// Blocks are deferred by default in login flow, so loadBlocks should not be called immediately
|
||||
assert.strictEqual(mockUserBlocks.loadBlocks.mock.callCount(), 0);
|
||||
});
|
||||
|
||||
test("throws if lockdown is active and user is not admin", async () => {
|
||||
mockAccessControl.isLockdownActive.mock.mockImplementation(() => true);
|
||||
mockAccessControl.isAdminEditor.mock.mockImplementation(() => false);
|
||||
|
||||
await assert.rejects(
|
||||
async () => await authService.login("0000000000000000000000000000000000000000000000000000000000000003"),
|
||||
{ code: "site-lockdown" }
|
||||
);
|
||||
});
|
||||
|
||||
test("allows login if lockdown is active but user is admin", async () => {
|
||||
mockAccessControl.isLockdownActive.mock.mockImplementation(() => true);
|
||||
mockAccessControl.isAdminEditor.mock.mockImplementation(() => true);
|
||||
|
||||
const pubkey = "0000000000000000000000000000000000000000000000000000000000000004";
|
||||
await authService.login(pubkey);
|
||||
assert.equal(getPubkey(), pubkey);
|
||||
});
|
||||
});
|
||||
|
||||
describe("logout", () => {
|
||||
test("clears state and calls reset on dependencies", async () => {
|
||||
// Setup initial state
|
||||
const pubkey = "0000000000000000000000000000000000000000000000000000000000000005";
|
||||
await authService.login(pubkey);
|
||||
|
||||
await authService.logout();
|
||||
|
||||
assert.equal(getPubkey(), null);
|
||||
assert.equal(getActiveProfilePubkey(), null);
|
||||
|
||||
assert.strictEqual(mockNostrClient.logout.mock.callCount(), 1);
|
||||
assert.strictEqual(mockUserBlocks.reset.mock.callCount(), 1);
|
||||
assert.strictEqual(mockRelayManager.reset.mock.callCount(), 1);
|
||||
});
|
||||
});
|
||||
|
||||
describe("requestLogin", () => {
|
||||
test("uses provider to login", async () => {
|
||||
const pubkey = "0000000000000000000000000000000000000000000000000000000000000001";
|
||||
mockAuthProvider.login.mock.mockImplementation(async () => ({ pubkey, authType: "nip07" }));
|
||||
|
||||
const result = await authService.requestLogin({ providerId: "nip07" });
|
||||
|
||||
assert.equal(result.pubkey, pubkey);
|
||||
assert.strictEqual(mockAuthProvider.login.mock.callCount(), 1);
|
||||
// requestLogin calls login() internally if autoApply is true (default)
|
||||
assert.equal(getPubkey(), pubkey);
|
||||
});
|
||||
|
||||
test("does not call login if autoApply is false", async () => {
|
||||
const pubkey = "0000000000000000000000000000000000000000000000000000000000000001";
|
||||
mockAuthProvider.login.mock.mockImplementation(async () => ({ pubkey, authType: "nip07" }));
|
||||
|
||||
await authService.requestLogin({ providerId: "nip07", autoApply: false });
|
||||
|
||||
assert.equal(getPubkey(), null);
|
||||
});
|
||||
});
|
||||
|
||||
describe("switchProfile", () => {
|
||||
test("switches to an existing profile", async () => {
|
||||
const pubkey1 = "0000000000000000000000000000000000000000000000000000000000000001";
|
||||
const pubkey2 = "0000000000000000000000000000000000000000000000000000000000000002";
|
||||
|
||||
await authService.login(pubkey1);
|
||||
// Reset mocks to clear login calls
|
||||
mockRelayManager.loadRelayList.mock.resetCalls();
|
||||
|
||||
// Mock login for switch
|
||||
mockAuthProvider.login.mock.mockImplementation(async () => ({ pubkey: pubkey2, authType: "nip07" }));
|
||||
|
||||
await authService.switchProfile(pubkey2, { providerId: "nip07" });
|
||||
|
||||
assert.equal(getPubkey(), pubkey2);
|
||||
assert.equal(getActiveProfilePubkey(), pubkey2);
|
||||
});
|
||||
|
||||
test("reorders saved profiles on switch", async () => {
|
||||
const pubkey1 = "0000000000000000000000000000000000000000000000000000000000000001";
|
||||
const pubkey2 = "0000000000000000000000000000000000000000000000000000000000000002";
|
||||
|
||||
await authService.login(pubkey1);
|
||||
await authService.login(pubkey2);
|
||||
|
||||
// At this point pubkey2 is active and likely last or first in savedProfiles depending on implementation.
|
||||
// mutateSavedProfiles pushes to end if new.
|
||||
// So [pubkey1, pubkey2].
|
||||
|
||||
let saved = getSavedProfiles();
|
||||
assert.equal(saved.length, 2);
|
||||
assert.equal(saved[1].pubkey, pubkey2);
|
||||
|
||||
// Switch back to pubkey1
|
||||
mockAuthProvider.login.mock.mockImplementation(async () => ({ pubkey: pubkey1, authType: "nip07" }));
|
||||
await authService.switchProfile(pubkey1);
|
||||
|
||||
saved = getSavedProfiles();
|
||||
// Should be moved to front?
|
||||
// Code says: if (index > 0) { const [moved] = draft.splice(index, 1); draft.unshift(moved); }
|
||||
// So yes, moved to front.
|
||||
assert.equal(saved[0].pubkey, pubkey1);
|
||||
});
|
||||
});
|
||||
});
|
||||
Reference in new issue
Block a user