Merge pull request #35 from PR0M3TH3AN/codex/fix-magnet-decoding-and-legacy-note-handling

Fix encoded magnet playback and surface legacy notes

js/app.js

@@ -716,7 +716,7 @@ class bitvidApp {
             return decodeURIComponent(value);
           } catch (err) {
             console.warn("Failed to decode data attribute:", err);
-            return "";
+            return value;
           }
         };
 
@@ -724,7 +724,8 @@ class bitvidApp {
         const encodedMagnet = trigger.getAttribute("data-play-magnet") || "";
 
         const url = decodeDataValue(encodedUrl);
-        const magnet = decodeDataValue(encodedMagnet);
+        const rawMagnet = decodeDataValue(encodedMagnet);
+        const magnet = safeDecodeMagnet(rawMagnet) || rawMagnet;
         const eventId = trigger.getAttribute("data-video-id");
 
         if (eventId) {

js/channelProfile.js

@@ -490,7 +490,15 @@ function localConvertEventToVideo(event) {
   const trimmedMagnet = typeof magnet === "string" ? magnet.trim() : "";
   const trimmedInfoHash = typeof infoHash === "string" ? infoHash.trim() : "";
   const playbackMagnet = trimmedMagnet || trimmedInfoHash;
-  const numericVersion = Number.isFinite(version) ? version : 0;
+  const parsedVersion =
+    typeof version === "number"
+      ? version
+      : typeof version === "string"
+        ? Number.parseInt(version, 10)
+        : Number.NaN;
+  const numericVersion = Number.isFinite(parsedVersion)
+    ? parsedVersion
+    : 0;
 
   const hasPlayableSource = Boolean(trimmedUrl) || Boolean(playbackMagnet);
   if (!hasPlayableSource) {

js/subscriptions.js

@@ -518,7 +518,15 @@ class SubscriptionsManager {
     const trimmedMagnet = typeof magnet === "string" ? magnet.trim() : "";
     const trimmedInfoHash = typeof infoHash === "string" ? infoHash.trim() : "";
     const playbackMagnet = trimmedMagnet || trimmedInfoHash;
-    const numericVersion = Number.isFinite(version) ? version : 0;
+    const parsedVersion =
+      typeof version === "number"
+        ? version
+        : typeof version === "string"
+          ? Number.parseInt(version, 10)
+          : Number.NaN;
+    const numericVersion = Number.isFinite(parsedVersion)
+      ? parsedVersion
+      : 0;
 
     const hasPlayableSource = Boolean(trimmedUrl) || Boolean(playbackMagnet);
     if (!hasPlayableSource) {