mirror of
https://github.com/PR0M3TH3AN/bitvid.git
synced 2026-11-05 04:12:25 +00:00
Add verbose logging and fix relay selection for watch history hydration
The watch history hydration stage was failing silently when relay connections were unstable or misconfigured. This commit: 1. Replaces the conditional debug logger with `devLogger.info` and `devLogger.warn` to ensure visibility of critical hydration steps. 2. Adds detailed logging for item counts, missing ID/address lists, filter generation, and fetch results. 3. Updates the relay selection logic to prioritize `nostrClient.readRelays` over `nostrClient.relays`. This ensures that hydration attempts query the user's specific read-configured relays, which is crucial for fetching metadata when generic relays may be write-only or restricted. These changes aid in diagnosing "Untitled video" issues and improve the robustness of the metadata fetch process.
This commit is contained in:
1 parent
93c88704e0
commit
b03d96f041
1 file changed
+18
-2
@@ -9,6 +9,7 @@ import {
|
||||
isWatchHistoryDebugEnabled,
|
||||
logWatchHistoryDebug,
|
||||
} from "../watchHistoryDebug.js";
|
||||
import { devLogger } from "../utils/logger.js";
|
||||
import {
|
||||
createBlacklistFilterStage,
|
||||
createWatchHistorySuppressionStage,
|
||||
@@ -18,11 +19,11 @@ import { isPlainObject } from "./utils.js";
|
||||
const WATCH_HISTORY_FEED_LOG_NAMESPACE = "watchHistoryFeed";
|
||||
|
||||
function debugInfo(message, details) {
|
||||
logWatchHistoryDebug(WATCH_HISTORY_FEED_LOG_NAMESPACE, "info", message, details);
|
||||
devLogger.info(`[${WATCH_HISTORY_FEED_LOG_NAMESPACE}] ${message}`, details || "");
|
||||
}
|
||||
|
||||
function debugWarn(message, details) {
|
||||
logWatchHistoryDebug(WATCH_HISTORY_FEED_LOG_NAMESPACE, "warn", message, details);
|
||||
devLogger.warn(`[${WATCH_HISTORY_FEED_LOG_NAMESPACE}] ${message}`, details || "");
|
||||
}
|
||||
|
||||
function normalizeActorCandidate(...values) {
|
||||
@@ -249,11 +250,13 @@ function checkLocalCacheForVideo(pointer) {
|
||||
|
||||
function createWatchHistoryHydrationStage() {
|
||||
return async function watchHistoryHydrationStage(items = [], context = {}) {
|
||||
debugInfo(`Starting hydration stage for ${items.length} items.`);
|
||||
const missing = [];
|
||||
const missingAddresses = [];
|
||||
const idMap = new Map();
|
||||
|
||||
const itemsToHydrate = items.filter(item => !item.video && item.pointer);
|
||||
debugInfo(`Items needing hydration: ${itemsToHydrate.length}`);
|
||||
let addressScanNeeded = false;
|
||||
|
||||
// First pass: try to resolve from cache for IDs, and collect addresses
|
||||
@@ -312,12 +315,15 @@ function createWatchHistoryHydrationStage() {
|
||||
}
|
||||
|
||||
if (!missing.length && !missingAddresses.length) {
|
||||
debugInfo("No missing items to fetch from relays.");
|
||||
return items;
|
||||
}
|
||||
|
||||
const uniqueIds = Array.from(new Set(missing));
|
||||
const uniqueAddresses = Array.from(new Set(missingAddresses));
|
||||
|
||||
debugInfo(`Fetching from relays. Missing IDs: ${uniqueIds.length}, Missing Addresses: ${uniqueAddresses.length}`);
|
||||
|
||||
const readRelays =
|
||||
Array.isArray(nostrClient?.readRelays) && nostrClient.readRelays.length
|
||||
? nostrClient.readRelays
|
||||
@@ -330,7 +336,10 @@ function createWatchHistoryHydrationStage() {
|
||||
|
||||
const relays = readRelays || fallbackRelays;
|
||||
|
||||
debugInfo("Selected relays for hydration:", relays);
|
||||
|
||||
if (!relays || !nostrClient?.pool) {
|
||||
debugWarn("Aborting hydration: No relays or pool available.");
|
||||
return items;
|
||||
}
|
||||
|
||||
@@ -361,9 +370,13 @@ function createWatchHistoryHydrationStage() {
|
||||
}
|
||||
}
|
||||
|
||||
debugInfo("Generated filters:", filters);
|
||||
|
||||
try {
|
||||
const events = await nostrClient.pool.list(relays, filters);
|
||||
debugInfo(`Hydration fetch returned ${events.length} events.`);
|
||||
|
||||
let matchCount = 0;
|
||||
for (const event of events) {
|
||||
if (!event) {
|
||||
continue;
|
||||
@@ -380,6 +393,7 @@ function createWatchHistoryHydrationStage() {
|
||||
if (target.metadata) {
|
||||
target.metadata.video = video;
|
||||
}
|
||||
matchCount++;
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -395,6 +409,7 @@ function createWatchHistoryHydrationStage() {
|
||||
if (target.metadata) {
|
||||
target.metadata.video = video;
|
||||
}
|
||||
matchCount++;
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -403,6 +418,7 @@ function createWatchHistoryHydrationStage() {
|
||||
debugWarn(`[watchHistoryFeed] Failed to convert event ${event.id}:`, err);
|
||||
}
|
||||
}
|
||||
debugInfo(`Hydrated ${matchCount} items from fetched events.`);
|
||||
} catch (error) {
|
||||
debugWarn("[watchHistoryFeed] Hydration fetch failed:", error);
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user