thePR0M3TH3AN/bitvid
1
0 Fork 0
mirror of https://github.com/PR0M3TH3AN/bitvid.git synced 2026-10-29 17:02:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(storage): validate signer identity before unlocking storage

Browse Source 
Prevents storage unlock failures and security risks when switching profiles by verifying that the active signer's public key matches the target profile. This ensures users are prompted to switch accounts in their NIP-07 extension if a mismatch occurs.

Fixes an issue where switching profiles caused the storage tab to break due to using the wrong decryption key.
This commit is contained in:
google-labs-jules[bot] committed 2026-01-25 18:09:28 +00:00
1 parent e162ee355d
commit d50110f685
1 file changed
+35 -15
Download Patch File Download Diff File Expand all files Collapse all files
js/ui/profileModalController.js
+35 -15
View File
@@ -9095,33 +9095,53 @@ export class ProfileModalController {
// ProfileModalController imports getActiveSigner.
if (!signer) {
this.showError("No active signer found. Please login.");
return;
this.showError("No active signer found. Please login.");
return;
}
if (
signer.pubkey &&
this.normalizeHexPubkey(signer.pubkey) !== pubkey
) {
this.showError(
`Signer account (${signer.pubkey.slice(
0,
8,
)}...) does not match profile (${pubkey.slice(
0,
8,
)}...). Please switch accounts in your extension.`,
);
return;
}
const storageService = this.services.storageService;
if (!storageService) {
this.showError("Storage service unavailable.");
return;
this.showError("Storage service unavailable.");
return;
}
if (this.storageUnlockBtn) {
this.storageUnlockBtn.disabled = true;
this.storageUnlockBtn.textContent = "Unlocking...";
this.storageUnlockBtn.disabled = true;
this.storageUnlockBtn.textContent = "Unlocking...";
}
try {
await storageService.unlock(pubkey, { signer });
this.showSuccess("Storage unlocked.");
this.populateStoragePane();
await storageService.unlock(pubkey, { signer });
this.showSuccess("Storage unlocked.");
this.populateStoragePane();
} catch (error) {
devLogger.error("Failed to unlock storage:", error);
this.showError("Failed to unlock storage. Ensure your signer supports NIP-04/44.");
devLogger.error("Failed to unlock storage:", error);
const message =
error && typeof error.message === "string"
? error.message
: "Failed to unlock storage. Ensure your signer supports NIP-04/44.";
this.showError(message);
} finally {
if (this.storageUnlockBtn) {
this.storageUnlockBtn.disabled = false;
this.storageUnlockBtn.textContent = "Unlock Storage";
}
if (this.storageUnlockBtn) {
this.storageUnlockBtn.disabled = false;
this.storageUnlockBtn.textContent = "Unlock Storage";
}
}
}