thePR0M3TH3AN/bitvid
1
0 Fork 0
mirror of https://github.com/PR0M3TH3AN/bitvid.git synced 2026-10-27 07:52:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2641 from PR0M3TH3AN/agents/weekly/interop-test-20260220-9990215938055218392

Browse Source 
test(ai): interop harness update and run
This commit is contained in:
thePR0M3TH3AN authored and GitHub committed 2026-02-20 09:00:23 -05:00
2 parents 93702846b0 5077c7f8d9
commit e4371efddb
2 files changed
+143 -32
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

docs/agents/task-logs/weekly/2026-02-20_13-08-24_interop-agent_completed.md
+35
View File
@@ -0,0 +1,35 @@
# bitvid-interop-agent Completion Log
**Date:** 2026-02-20
**Agent:** bitvid-interop-agent
**Status:** Success
## Summary
The interop-agent executed the protocol & interop test harness to verify correct behavior of Nostr event creation, publishing, and round-tripping.
### Key Actions
1. **Harness Update**: Updated `scripts/agent/interop-test.mjs` to robustly test:
* **Video Post**: Verifies creation, signing (Kind 30078), publishing, and retrieval with correct content.
* **View Event**: Verifies creation and publishing of view telemetry (Kind 30079 equivalent).
* **Direct Message**: Verifies NIP-04 encryption/decryption roundtrip using `js/dmDecryptor.js` and `NostrClient` capabilities.
* **Ephemeral Identity**: Tests use generated ephemeral keys and do not persist them.
* **Relay Interaction**: Auto-starts a local relay for hermetic testing.
2. **Verification**:
* Executed the test harness successfully against a local relay.
* Confirmed `Video Post` integrity (ID matching, signature verification implicit via relay acceptance).
* Confirmed `View Event` publishing.
* Confirmed `DM` decryption using the recipient's ephemeral keys.
### Findings
* Identified and worked around a known issue where `NostrClient` (via `nostrClientRegistry`) uses global state for the active signer, which complicates multi-tenant testing in a single process.
* **Fix**: Explicitly passed the `signingAdapter` to `sendDirectMessage` in the test harness to ensure the correct sender identity is used.
### Artifacts
* `scripts/agent/interop-test.mjs`: Updated test harness.
* `artifacts/interop-20260220.json`: Test execution summary.
* `artifacts/interop-20260220.log`: Detailed execution log.
## Next Steps
* Continue monitoring interop with public relays in future runs (optional, controlled via `--relays` flag).
* Consider refactoring `NostrClient` or `nostrClientRegistry` to support isolated instances better for testing purposes.
scripts/agent/interop-test.mjs
+108 -32
View File
@@ -2,9 +2,11 @@ import WebSocket from 'ws';
import { webcrypto } from 'node:crypto';
import fs from 'node:fs';
import path from 'node:path';
import { startRelay } from './simple-relay.mjs';
import { fileURLToPath } from 'url';
import { spawn } from 'child_process';
import { NostrClient } from '../../js/nostr/client.js';
import { buildVideoPostEvent, buildViewEvent } from '../../js/nostrEventSchemas.js';
import { decryptDM } from '../../js/dmDecryptor.js';
import { generateSecretKey, getPublicKey, nip19 } from 'nostr-tools';
// --- Polyfills for Node.js environment ---
@@ -28,12 +30,13 @@ if (typeof globalThis.localStorage === 'undefined') {
if (typeof globalThis.window === 'undefined') {
globalThis.window = globalThis;
globalThis.window.localStorage = globalThis.localStorage;
// Mock runtime overrides for schemas
globalThis.window.bitvidNostrEventOverrides = {};
}
if (typeof globalThis.navigator === 'undefined') {
globalThis.navigator = { userAgent: 'node' };
}
if (typeof globalThis.document === 'undefined') {
// Minimal document mock for some utility checks
globalThis.document = {
createElement: () => ({}),
body: {},
@@ -48,7 +51,7 @@ function parseArgs() {
relays: [],
burst: 3,
timeout: 30, // seconds
out: `artifacts/interop-${new Date().toISOString().split('T')[0]}.json`,
out: `artifacts/interop-${new Date().toISOString().split('T')[0].replace(/-/g, '')}.json`,
confirmPublic: false
};
@@ -85,7 +88,7 @@ function log(level, message, data = null) {
const entry = `[${timestamp}] [${level.toUpperCase()}] ${message}`;
console.log(entry);
if (data) {
console.dir(data, { depth: null, colors: true });
// console.dir(data, { depth: null, colors: true });
}
logs.push({ timestamp, level, message, data });
}
@@ -99,7 +102,7 @@ function saveArtifacts(config, results) {
// Save JSON summary
const summary = {
timestamp: new Date().toISOString(),
config: { ...config, relays: config.relays }, // include actual used relays
config: { ...config, relays: config.relays },
results,
logs
};
@@ -113,6 +116,25 @@ function saveArtifacts(config, results) {
log('info', `Log saved to ${logPath}`);
}
// --- Helper: Start Local Relay ---
async function startLocalRelay() {
const scriptDir = path.dirname(fileURLToPath(import.meta.url));
const relayScript = path.resolve(scriptDir, 'simple-relay.mjs');
const port = 8899;
log('info', `Starting local relay on port ${port}...`);
const relayProcess = spawn('node', [relayScript], {
env: { ...process.env, PORT: port.toString() },
stdio: 'ignore', // 'inherit' for debug
detached: false
});
// Allow relay to boot
await new Promise(r => setTimeout(r, 2000));
return { process: relayProcess, url: `ws://localhost:${port}` };
}
// --- Main Test Logic ---
async function runTests() {
const config = parseArgs();
@@ -122,16 +144,15 @@ async function runTests() {
dm: { status: 'pending' }
};
let relayServer = null;
let relayProcess = null;
try {
// 1. Setup Relays
if (config.relays.length === 0) {
log('info', 'No relays specified. Starting local test relay...');
const port = 8899;
relayServer = startRelay(port);
config.relays = [`ws://localhost:${port}`];
log('info', `Local relay started at ws://localhost:${port}`);
const local = await startLocalRelay();
relayProcess = local.process;
config.relays = [local.url];
} else {
log('info', `Using configured relays: ${config.relays.join(', ')}`);
// Security check for public relays
@@ -156,12 +177,13 @@ async function runTests() {
const pk = getPublicKey(sk);
const npub = nip19.npubEncode(pk);
// We manually initialize internal managers since we are in Node
await client.ensurePool();
await client.connectToRelays();
await client.registerPrivateKeySigner({ privateKey: skHex, pubkey: pk });
const signer = await client.registerPrivateKeySigner({ privateKey: skHex, pubkey: pk });
log('info', `${name} initialized`, { pubkey: pk, npub });
return { client, sk, skHex, pk, npub };
return { client, sk, skHex, pk, npub, signer };
};
const alice = await setupClient('Alice');
@@ -196,6 +218,8 @@ async function runTests() {
if (!fetched) {
throw new Error('Failed to fetch published video event');
}
// Validation
if (fetched.title !== 'Interop Test Video') {
throw new Error(`Content mismatch: expected 'Interop Test Video', got '${fetched.title}'`);
}
@@ -221,9 +245,27 @@ async function runTests() {
const { signedEvent } = await alice.client.signAndPublishEvent(viewEvent);
log('info', 'View event published', { id: signedEvent.id });
// Wait for propagation
await new Promise(r => setTimeout(r, 500));
// Verify reception
// Since View Events (Kind 30078/10003?) wait, View Event is Kind 30078 with t=view?
// Let's check schema. KIND_WATCH_HISTORY = 30078 (wait, that's video post kind usually, but schema says WATCH_HISTORY_KIND).
// Actually viewEvent is KIND_WATCH_HISTORY (30078) with specific tags.
// Let's check `getNostrEventSchema(NOTE_TYPES.VIEW_EVENT)`.
// It says kind: WATCH_HISTORY_KIND (imported from config).
// But usually view events are just data events.
// Anyway, let's fetch it back by ID to confirm.
const fetchedView = await alice.client.getEventById(signedEvent.id);
if (!fetchedView) {
throw new Error('Failed to fetch published view event');
}
results.viewEvent.publishedId = signedEvent.id;
results.viewEvent.status = 'pass';
log('info', 'View Event verified successfully (publish only)');
log('info', 'View Event verified successfully');
} catch (e) {
log('error', 'View Event test failed', e);
results.viewEvent.status = 'fail';
@@ -234,37 +276,67 @@ async function runTests() {
results.viewEvent.status = 'skipped';
}
// --- Test 3: DM Roundtrip (NIP-04) ---
log('info', '--- Test 3: DM Roundtrip (NIP-04) ---');
// --- Test 3: DM Roundtrip (NIP-04/17) ---
log('info', '--- Test 3: DM Roundtrip ---');
try {
const message = `Secret message ${Date.now()}`;
// Sending
const sendResult = await alice.client.sendDirectMessage(bob.npub, message, null, { useNip17: false });
// Sending from Alice to Bob
// Note: sendDirectMessage automatically chooses NIP-04 or NIP-17 based on options.
// We will try default (NIP-04 usually, unless attachments present).
// The prompt asks for "DM encrypt/decrypt roundtrip using js/dmDecryptor.js".
// Explicitly pass signingAdapter to avoid global registry lookup issues in test harness
const sendResult = await alice.client.sendDirectMessage(bob.npub, message, null, {
useNip17: false,
signingAdapter: alice.signer
});
if (!sendResult.ok) {
throw new Error(`Send failed: ${sendResult.error}`);
}
log('info', 'DM sent', { message });
log('info', 'DM sent (NIP-04)', { message });
// Wait for propagation
await new Promise(r => setTimeout(r, 1000));
await new Promise(r => setTimeout(r, 2000));
// Receiving
// We need to fetch messages for Bob.
// NostrClient.listDirectMessages usually assumes the active user is the one fetching.
// We can use bob.client.listDirectMessages() since bob.client has Bob's signer active.
// Note: listDirectMessages filters by 'authors' or 'p' tags relative to 'actorPubkey'.
// We fetch the DM event as Bob.
// We need to list messages.
// Note: listDirectMessages does a whole workflow. We want to test `decryptDM` specifically.
// So we will manually fetch the event using pool.list and then pass it to decryptDM.
// Force Bob's client to see Bob as the actor
const dms = await bob.client.listDirectMessages(bob.pk, { limit: 10 });
const received = dms.find(m => m.plaintext === message);
const filters = [{
kinds: [4], // NIP-04
'#p': [bob.pk],
authors: [alice.pk],
limit: 1
}];
if (!received) {
log('debug', 'Received DMs', dms.map(m => m.plaintext));
throw new Error('Bob did not receive/decrypt the DM');
const events = await bob.client.pool.list(bob.client.readRelays, filters);
const dmEvent = events.find(e => e.kind === 4);
if (!dmEvent) {
throw new Error('Bob could not find the DM event on relay');
}
log('info', 'DM received and decrypted', { plaintext: received.plaintext });
log('info', 'DM Event fetched', { id: dmEvent.id });
// Decrypt using js/dmDecryptor.js
// We need a decrypt context for Bob.
const context = await bob.client.buildDmDecryptContext(bob.pk);
const result = await decryptDM(dmEvent, context);
if (!result.ok) {
throw new Error(`Decryption failed: ${result.errors?.[0]?.error?.message || 'Unknown error'}`);
}
if (result.plaintext !== message) {
throw new Error(`Content mismatch. Expected '${message}', got '${result.plaintext}'`);
}
log('info', 'DM decrypted successfully via decryptDM', { plaintext: result.plaintext });
results.dm.status = 'pass';
} catch (e) {
log('error', 'DM test failed', e);
@@ -275,11 +347,15 @@ async function runTests() {
} catch (error) {
log('error', 'Fatal error in test runner', error);
} finally {
if (relayServer) {
if (relayProcess) {
log('info', 'Closing local relay...');
relayServer.close();
relayProcess.kill();
}
// Force close clients
// (There isn't a clean close method exposed on NostrClient that closes the pool,
// but we can exit process)
saveArtifacts(config, results);
const hasFailure = Object.values(results).some(r => r.status === 'fail');