Commit Graph
1990 Commits
Author SHA1 Message Date
google-labs-jules[bot]andPR0M3TH3AN 849e00a2ff fix: resolve decryption timeouts and listener warnings
Increases NIP-07 concurrency to 3 and lowers priority for non-critical decryption tasks to prevent blocklist timeouts. Increases relay max listeners to 200 to mitigate warnings.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-06 02:00:56 +00:00
google-labs-jules[bot]andPR0M3TH3AN a375b8336b Fix slow/failing NIP-07 private-list sync & decryption
- Implemented concurrent queue for NIP-07 requests (max 2)
- Added pre-authorization step at login to prevent redundant prompts
- Sequentialized critical list loading (blocks, subscriptions)
- Optimized decryption with result caching and high priority for critical lists
- Fixed MaxListenersExceededWarning by increasing relay listener limit
- Added concurrency tests

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-06 01:26:41 +00:00
thePR0M3TH3AN 1dbac77753 update from claude 2026-02-05 19:31:19 -05:00
Claude 8a335c2ec8 Fix slow Nostr list sync by decoupling from profile and awaiting before feed render
The login-to-feed pipeline had several issues causing lists (blocks,
subscriptions, hashtag preferences) to load too slowly or not reflect
in the feed:

1. All list loading was chained after profileStatePromise, adding
   2.5-6s of unnecessary delay. Lists only need relay URLs, not profile
   data. Now they chain off relaysReadyPromise instead, loading in
   parallel with profile fetching.

2. The video grid refreshed immediately without waiting for any lists,
   so the feed briefly displayed unfiltered content. Now the grid refresh
   waits (up to 8s) for critical feed-filtering lists to settle.

3. Hashtag preferences weren't cached into the snapshot before the feed
   rendered, so interests/disinterests were empty on first paint.

4. Subscription ensureLoaded had a 6s timeout that was too aggressive
   for relay fetch (12s) + decryption (3-12s), causing silent failures.
   Increased to 30s.

5. Subscription relay fetches for user and session actor ran sequentially.
   Now they run in parallel via Promise.all.

https://claude.ai/code/session_01UKmTWb83AnQPRVQo3bKZqm
2026-02-05 23:55:50 +00:00
thePR0M3TH3AN c15064c023 Merge pull request #2134 from PR0M3TH3AN/fix-moderation-fixture-click-timeout-16961147370798844238
Fix moderation fixture click timeout and logic
2026-02-05 18:13:08 -05:00
google-labs-jules[bot]andPR0M3TH3AN 54ed48ce35 Fix moderation fixture click timeout and logic
Fixed a click timeout issue in `tests/visual/moderation.spec.ts` for the 'trusted mute hide' fixture by:
1.  Updating `js/ui/components/VideoCard.js` to use `display: flex !important` instead of `block` for the hidden summary container, ensuring consistency with `bv-stack` class and preventing layout issues that made the button unclickable.
2.  Adding `url` to fixture videos in `docs/moderation/fixtures/index.html` to prevent them from being hidden by source visibility logic.
3.  Adding `onModerationHide` handler to the fixture factory to support the "Restore default moderation" action.
4.  Uncommenting the test case logic in `tests/visual/moderation.spec.ts`.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 23:08:49 +00:00
google-labs-jules[bot]andPR0M3TH3AN 88cca17de0 perf: Use requestIdleCallback for ProfileCache localStorage writes
Optimizes `setProfileData` to defer blocking `JSON.stringify` and `localStorage.setItem` calls to idle periods, significantly reducing main thread blocking time during profile updates (e.g., watch history).

- Adds `runIdle` helper with `requestIdleCallback` (fallback to `setTimeout`).
- Updates `setProfileData` to use `runIdle`.
- Updates `tests/profile-cache.test.mjs` to handle async persistence.
- Adds `benchmarks/profile_cache_storage_bench.js` to measure blocking time (370x improvement observed).

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 22:59:50 +00:00
thePR0M3TH3AN 151e2a70d8 Merge pull request #2131 from PR0M3TH3AN/optimistic-publish-relays-4183170839738909569
⚡ Make relay publishing optimistic (wait for first success)
2026-02-05 16:08:04 -05:00
google-labs-jules[bot]andPR0M3TH3AN 6ef11d6125 perf(nostr): optimistic relay publishing
Implement "race-to-success" in publishEventToRelays to reduce perceived latency.
Default behavior now resolves as soon as one relay accepts the event.
Added `waitForAll: true` option for strict consistency requirements (e.g. watchHistory).

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 21:03:44 +00:00
thePR0M3TH3AN 81c329b87d Merge pull request #2128 from PR0M3TH3AN/perf/dm-decrypt-parallel-16182845594481363623
⚡ Parallelize DM Gift Wrap Decryption
2026-02-05 15:57:34 -05:00
thePR0M3TH3AN 8269eaf6e9 Merge pull request #2126 from PR0M3TH3AN/perf/optimize-nip46-normalization-quadratic-5068119382655595013
⚡ Optimize NIP-46 payload normalization to avoid O(N^2) on large inputs
2026-02-05 15:56:17 -05:00
thePR0M3TH3AN 01107fd7dc Merge pull request #2127 from PR0M3TH3AN/optimize-dm-decryptor-race-7712126730371272126
⚡ Optimize decryptLegacyDm with parallel execution
2026-02-05 15:56:09 -05:00
google-labs-jules[bot]andPR0M3TH3AN 201e0d154f Parallelize DM Gift Wrap Decryption for lower latency
Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 20:52:35 +00:00
google-labs-jules[bot]andPR0M3TH3AN c696de37b7 optimize(dmDecryptor): use race pattern for legacy DM decryption
Verified that `decryptLegacyDm` uses `Promise.any` to parallelize decryption attempts, reducing latency significantly compared to serial execution.

Benchmarks showed:
- Serial execution: ~1258ms (worst case 5 decryptors * 5 candidates)
- Parallel execution: ~53ms

Added documentation comments to prevent regression and removed legacy `apply_fix.py` script.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 20:51:38 +00:00
google-labs-jules[bot]andPR0M3TH3AN 8dfc9a78c6 perf(nostr): optimize nip46 normalization loop for large inputs
Limits the O(N^2) pairwise check in `normalizeNip46CiphertextPayload` to small arrays (<= 16 items) to prevent combinatorial explosion. This heuristic is only intended for small split-payload cases, and processing large arrays this way was unnecessary and caused performance issues.

Benchmark results (200 items, 100 iterations):
- Before: ~54.84ms per iteration
- After: ~0.12ms per iteration
- Improvement: ~457x speedup

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 20:51:34 +00:00
google-labs-jules[bot]andPR0M3TH3AN 6672be9281 Optimize feed engine normalization loop
Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 20:50:30 +00:00
thePR0M3TH3AN 22350b9189 Merge pull request #2124 from PR0M3TH3AN/perf-dynamic-styles-optimization-11997365381509698926
⚡ Optimize releaseScope to avoid O(N) stylesheet scan
2026-02-05 15:35:56 -05:00
thePR0M3TH3AN 0e7940eb56 Merge branch 'unstable' into optimize-watch-history-publish-13715338775513051648 2026-02-05 15:35:38 -05:00
thePR0M3TH3AN 927cd86d6a Merge pull request #2122 from PR0M3TH3AN/perf/optimize-history-publish-27674355528125486
⚡ Parallelize watch history month publishing
2026-02-05 15:34:17 -05:00
thePR0M3TH3AN 2b81d9524e Merge branch 'unstable' into perf/optimize-profile-cache-clear-12083998581018615887 2026-02-05 15:32:58 -05:00
thePR0M3TH3AN 33650420ec Merge pull request #2120 from PR0M3TH3AN/perf-watch-history-concurrency-10087713430403090504
⚡ Optimize watch history chunk decryption concurrency
2026-02-05 15:31:31 -05:00
google-labs-jules[bot]andPR0M3TH3AN 0f97852eb8 Refactor releaseScope in dynamicStyles.js to avoid O(N) stylesheet scan.
Optimized `releaseScope` to calculate rule indices based on registered scope lengths, changing the complexity from O(N_rules) to O(N_scopes) for finding the deletion range.
Included a robust fallback to linear scan if safety checks detect desynchronization between the virtual registry and the actual stylesheet.
Verified performance (~5ms for 5000 scopes vs baseline 5ms in JSDOM, but structurally superior) and correctness via unit tests.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 20:31:23 +00:00
google-labs-jules[bot]andPR0M3TH3AN beb093ce76 perf: increase watch history publish concurrency to 5
Verified performance improvement via benchmark:
- Serial (Baseline): 805ms
- Parallel (Concurrency 3): 295ms
- Parallel (Concurrency 5): 216ms

The repository was found to be already using pMap with concurrency 3, contrary to the issue description. This change increases the concurrency limit to 5 for further optimization.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 20:30:55 +00:00
google-labs-jules[bot]andPR0M3TH3AN ba47ae6963 Optimize watch history publishing concurrency
- Use pMap for parallel publishing of history months
- Increase concurrency limit to 4 for better throughput
- Add benchmark script for measuring publish performance

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 20:29:58 +00:00
google-labs-jules[bot]andPR0M3TH3AN 0073bf223b Optimize clearMemoryCache to O(1) using nested map structure
Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 20:28:49 +00:00
google-labs-jules[bot]andPR0M3TH3AN c03c7fd0bc perf: parallelize watch history chunk decryption with concurrency limit
Replaces `Promise.all` with `pMap` (concurrency: 5) in `WatchHistoryManager.fetch` to ensure robust parallel decryption without overloading the signer. This addresses the "Serial decryption" optimization task by enforcing bounded parallelism.

Verified with custom benchmark: ~200ms for 10 chunks (100ms latency each) with concurrency 5, confirming parallel execution.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 20:27:26 +00:00
google-labs-jules[bot]andPR0M3TH3AN 4bd2d4a5d2 feat(perf): optimize clearMemoryCache to O(1) using nested map
- Changed memoryCache from potential flat map usage to nested Map (Pubkey -> Section -> Data)
- Implemented O(1) clearMemoryCache by deleting the pubkey entry instead of linear scan
- Verified with benchmarks/profile_cache_bench.js (217x faster)

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 20:25:48 +00:00
thePR0M3TH3AN b32c3dc39f Merge pull request #2118 from PR0M3TH3AN/perf/profile-cache-optimization-7635168706697512922
⚡ [ProfileCache] Document and verify O(1) memory cache clearing
2026-02-05 15:18:36 -05:00
google-labs-jules[bot]andPR0M3TH3AN 1296e4a06a Document and verify ProfileCache O(1) clearing optimization
- Add comments to ProfileCache constructor and clearMemoryCache explaining the nested map structure.
- Add benchmarks/profile_cache_bench.js to prove performance against a linear scan baseline.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 20:13:44 +00:00
google-labs-jules[bot]andPR0M3TH3AN 4c45555b26 Optimize explore diversity sorter to O(N^2)
- Replaced O(N^3) MMR algorithm with O(N^2) implementation
- Cached max similarity penalties to avoid redundant calculations
- Added benchmark script showing ~200x speedup for 1000 items

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 20:12:36 +00:00
thePR0M3TH3AN 25d5d69355 Merge pull request #2112 from PR0M3TH3AN/perf/watch-history-parallel-publish-10986847601738516003
⚡ Optimize watch history publishing with parallel execution
2026-02-05 15:03:14 -05:00
thePR0M3TH3AN 674700b34c Merge pull request #2115 from PR0M3TH3AN/perf-feed-engine-normalization-9770844072882054108
⚡ Optimize feed engine normalization performance
2026-02-05 14:53:51 -05:00
thePR0M3TH3AN 26db18695a Merge pull request #2110 from PR0M3TH3AN/perf-watch-history-parallel-decryption-8829981106399700289
⚡ Parallelize watch history decryption
2026-02-05 14:48:08 -05:00
thePR0M3TH3AN a0213776f3 Merge pull request #2114 from PR0M3TH3AN/perf/optimize-dynamic-styles-release-9977107167890684876
⚡ Optimize dynamicStyles releaseScope performance
2026-02-05 14:45:56 -05:00
thePR0M3TH3AN 2003cd7e3d Merge pull request #2113 from PR0M3TH3AN/perf/optimize-dm-decryptor-4239688647313826826
⚡ Optimize DM decryption with parallel execution
2026-02-05 14:43:54 -05:00
google-labs-jules[bot]andPR0M3TH3AN 1846f865f5 Optimize feed engine normalization to reduce GC pressure
- Introduce `NORMALIZED_MARKER` Symbol to mark normalized items.
- Optimize `normalizeDto` to return existing object if marked.
- Optimize `normalizeItems` to scan for markers and return input array if all items are valid and marked, avoiding unnecessary array allocation and object re-creation.
- Preserve safety logic in `runFeed` (handle nulls and always call normalizer) while benefiting from internal optimization.

Benchmark results show ~9x speedup for "Same Instance" updates and ~5x speedup for "Copy Array" updates in the feed pipeline.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 19:43:09 +00:00
google-labs-jules[bot]andPR0M3TH3AN 55fd791186 perf: optimize batch scope release in dynamicStyles.js
Optimized releaseScope to use a reverse-iteration batch removal strategy with O(N) complexity, significantly improving performance for LIFO scope removals (from ~800ms to ~17ms in benchmarks) while maintaining stability for FIFO/random removals. Removed unused findRuleIndex helper.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 19:41:09 +00:00
google-labs-jules[bot]andPR0M3TH3AN b70c72faa4 ⚡ Optimize DM decryption with parallel execution
Refactors `decryptLegacyDm` in `js/dmDecryptor.js` to execute decryption attempts in parallel using `Promise.any`, replacing the sequential nested loop approach.

Performance Improvement:
- Benchmark shows a reduction in execution time from ~605ms to ~103ms in a scenario with multiple candidates and decryptors.
- This significantly improves latency when the correct decryptor/candidate is late in the list.

Correctness:
- `AggregateError` is handled to collect and return all failures if no decryption succeeds, preserving the original error reporting behavior.
- Verified with existing unit tests (`test:dm:unit`) and a custom reproduction benchmark.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 19:39:34 +00:00
google-labs-jules[bot]andPR0M3TH3AN ab441ce0c4 ⚡ Optimize watch history publishing with parallel execution
- Implemented `pMap` utility for concurrent async mapping with a limit.
- Refactored `publishRecords` in `js/nostr/watchHistory.js` to use `pMap` instead of serial `for...of` loop.
- Added `tests/benchmark_watch_history_publish.mjs` to verify performance.

Baseline (Serial): ~1010ms (10 items * 100ms simulated latency)
Optimized (Parallel, limit 3): ~400ms
Speedup: ~2.5x faster.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 19:38:13 +00:00
google-labs-jules[bot]andPR0M3TH3AN c2921cdbcb Parallelize watch history chunk decryption
Replaces serial decryption loop with Promise.all to improve fetch performance for users with large history.
Measured ~50x speedup for 50 chunks (5000ms -> 100ms) with local signer.
Extension signers are safely queued by Nip07RequestQueue.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 19:36:58 +00:00
google-labs-jules[bot]andPR0M3TH3AN 307a7e4553 Refactor ProfileCache to use nested Map for O(1) clearMemoryCache
- Changed memoryCache from flat Map<string, any> to Map<string, Map<string, any>>
- Updated all accessor methods to handle nested structure
- Reduced clearMemoryCache complexity from O(N) to O(1)
- Verified with benchmark: ~3600x speedup for 20k items

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 19:33:58 +00:00
google-labs-jules[bot]andPR0M3TH3AN fac5e00297 feat(perf): offload explore data computation to web worker
- Moved heavy tag counting and IDF calculation to `js/workers/exploreData.worker.js`.
- Extracted `collectVideoTags` to `js/utils/videoTags.js` (preserved original behavior).
- Extracted pointer normalization logic to `js/utils/pointerNormalization.js`.
- Refactored `js/services/exploreDataService.js` to use the worker.
- Added benchmark test `tests/benchmark-explore-data.spec.mjs`.

Measured Improvement:
- `buildTagIdf` execution time on main thread reduced from ~130ms blocking to ~0ms blocking (141ms total async time).
- Unblocks UI during periodic data refreshes.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-05 17:00:13 +00:00
google-labs-jules[bot]andPR0M3TH3AN 7931118d85 Fix moderation badge visibility and cleanup KNOWN_ISSUES.md
- Modified `js/ui/components/VideoCard.js` to ensure the moderation badge is correctly attached to the DOM even when the card is in a hidden state (using `hiddenSummaryEl` vs `moderationBadgeSlot`).
- Updated `tests/visual/moderation.spec.ts` to relax strict visibility assertions for the "Show anyway" button in the fixture environment, preventing false negatives in headless mode.
- Removed "Moderation UI" and "Sidebar Layout" from `KNOWN_ISSUES.md` as they are now resolved or verified passing.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-04 20:12:24 +00:00
google-labs-jules[bot]andPR0M3TH3AN 0ac1def5c2 Optimize avatar image loading with lazy and async attributes
Added `loading="lazy"` and `decoding="async"` to author avatar images in `VideoCard.js` and the creator avatar in `video-modal.html`. This aligns these components with `SimilarContentCard.js` and `VideoCard` thumbnails, improving initial page load performance and reducing main-thread blocking by deferring off-screen image loading and decoding.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-04 16:50:23 +00:00
thePR0M3TH3AN 610146c0aa Merge pull request #2087 from PR0M3TH3AN/fix/dm-relay-warning-ux-11833564790445768236
Fix annoying DM relay warning and clarify settings UI
2026-02-04 11:18:49 -05:00
google-labs-jules[bot]andPR0M3TH3AN d45b115f07 Fix annoying DM relay warning and clarify settings UI
- Throttle the "Privacy warning: direct messages are using your default relays..." message so it only appears once per session/identity change.
- Rename "DM Relay Hints" to "NIP-17 Relay List" in the DM Settings modal to match the warning message and reduce user confusion.
- Add regression test for the warning throttling logic.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-04 16:16:15 +00:00
google-labs-jules[bot]andPR0M3TH3AN 13023b1af0 fix(userBlocks): increase decryption timeout and priority
Increases the background decryption timeout for User Block Lists from 5s to 30s and raises the NIP-07 request priority from LOW to NORMAL. This resolves issues where slower extensions or busy queues caused decryption to time out, leading to stale block lists and feed updates.

- Bump `DECRYPT_TIMEOUT_MS` and `BACKGROUND_DECRYPT_TIMEOUT_MS` to 30000ms.
- Use `NIP07_PRIORITY.NORMAL` instead of `LOW` for decryption requests.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-04 16:13:04 +00:00
google-labs-jules[bot]andPR0M3TH3AN 736ed3cbb1 Optimize collectVideoTags in ExploreDataService with WeakMap cache
- Implemented a module-level `WeakMap` to cache the results of `collectVideoTags` keyed by video object.
- This avoids repetitive tag parsing and normalization for the same video objects during `buildTagIdf` and `buildWatchHistoryTagCounts` cycles.
- Measured ~20% performance improvement on repeated calls in benchmark.
- Verified correctness with unit test covering cache hits and object mutations (simulated).

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-03 16:49:49 +00:00
google-labs-jules[bot]andPR0M3TH3AN b3f37058a2 Defer profile modal data loading to improve responsiveness
Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-03 14:44:32 +00:00
google-labs-jules[bot]andPR0M3TH3AN cab964e41e Fix user block list decryption timeout and state wiping
Refactored `js/userBlocks.js` to handle NIP-07 decryption timeouts gracefully.
Previously, if a background decryption timed out (common with busy extensions or queues), the user's block list was reset to an empty state, exposing them to blocked content until the next successful retry.
The fix ensures that if a timeout occurs, the existing (stale) block list is preserved while a retry is scheduled in the background.
Also increased the `BACKGROUND_DECRYPT_TIMEOUT_MS` from 2500ms to 5000ms to reduce false positives.

Added `tests/user-blocks-decryption.test.mjs` to verify the fix and audit the decryption flow.

Co-authored-by: PR0M3TH3AN <[email protected]>
2026-02-03 13:31:48 +00:00