Commit Graph
16 Commits
Author SHA1 Message Date
google-labs-jules[bot] 6735eb0dea Fix comment event validation test case
Added missing root kind (K) and root author (P) tags to the mock event in `tests/nostr/comment-events.test.mjs`. This fixes a test failure where the event was being rejected by strict validation logic in `isVideoCommentEvent` because the tags derived from the definition address were not present in the event itself.

The added tags use whitespace and mixed casing to preserve the test's intent of verifying robust tag parsing.
2026-01-14 03:42:53 +00:00
google-labs-jules[bot] f3075b8929 Fix unit tests for comment events and improve target normalization logic
- Updated `subscribeVideoComments` test to expect `#A` filter keys (uppercase), matching the implementation and other tests.
- Improved `normalizeCommentTarget` in `js/nostr/commentEvents.js` to correctly derive `parentKind` and `parentAuthorPubkey` from the `parentCommentEvent` object if available.
- Enhanced `parentAuthorRelay` resolution to look up the specific `p` tag for the author pubkey instead of defaulting to the first found `p` tag.
- Updated `publishComment` test expectations to remove duplicate tags (implementation correctly deduplicates) and reflect improved metadata derivation (correct `K` tag and `P` relay).
- Added async wait to `subscribeVideoComments` test to prevent race condition in unsubscribe assertion.
2026-01-14 03:22:25 +00:00
google-labs-jules[bot] d6882fb5bb Fix CI, environment, linting, and unit test issues
- Fix circular dependency in `js/adminListStore.js` by importing from `js/nostrClientRegistry.js`.
- Update `js/services/hashtagPreferencesService.js` to include legacy kind 30005 in filters.
- Fix JSDOM mocking in `tests/modal-accessibility.test.mjs` (navigator getter) and `UploadModal` selectors.
- Add `getRoot()` to `js/ui/components/UploadModal.js` for API consistency.
- Update `tests/magnet-utils.test.mjs` expectations to reflect removed default tracker.
- Mock `ensureActiveSignerForPubkey` in `tests/moderation/submit-report.test.mjs`.
- Fix mock loader path in `tests/moderation/trust-seeds.test.mjs` to target `trustBootstrap.js`.
- Fix duplicate pointer tags in `js/nostrEventSchemas.js`'s `buildCommentEvent`.
- Update `tests/nostr/comment-events.test.mjs` and `tests/comment-event-builder.test.mjs` to match current code behavior (legacy kinds, unique tags).
2026-01-13 20:32:06 +00:00
thePR0M3TH3AN 5979d4e25f Use uppercase tags for comment events 2026-01-06 16:22:49 -05:00
thePR0M3TH3AN 8a111d8ee8 Handle lowercase root identifiers when fetching comments 2025-11-12 20:56:15 -05:00
thePR0M3TH3AN c882139e90 Fix comment event matching for uppercase addresses 2025-11-04 16:52:12 -05:00
thePR0M3TH3AN 8ad7d82a70 update 2025-11-03 21:49:10 -05:00
thePR0M3TH3AN d9b45ed867 Ensure comment events keep root e tags alongside addresses 2025-11-03 09:56:33 -05:00
thePR0M3TH3AN 59161df063 Require active signer for comment publishing 2025-10-30 11:39:09 -04:00
thePR0M3TH3AN 28acf98cda Add uppercase comment filters and update validation logic 2025-10-29 15:38:08 -04:00
thePR0M3TH3AN 56b31f324e Improve comment metadata propagation 2025-10-29 15:24:10 -04:00
thePR0M3TH3AN eeee978134 Add NIP-22 metadata to video comment events 2025-10-29 14:38:59 -04:00
thePR0M3TH3AN 7dc59af49b Handle video-only comment targets 2025-10-29 12:09:04 -04:00
thePR0M3TH3AN 9908caafa8 Allow legacy comment targets without definition pointers 2025-10-29 11:36:52 -04:00
thePR0M3TH3AN d1d4fa150c Use kind 1111 comments with address-first tags 2025-10-29 07:45:34 -04:00
thePR0M3TH3AN 9717342bfe Add Nostr video comment helpers 2025-10-24 14:36:19 -04:00