mirror of
https://github.com/PR0M3TH3AN/bitvid.git
synced 2026-10-28 16:32:28 +00:00
google-labs-jules[bot]
c3f19f4bf5
This commit adds a minimal reproducer script that demonstrates a bug where comments on an original video are hidden when viewing that video via a Repost (Kind 6). The issue stems from `normalizeCommentTarget` using the Repost's metadata (Kind 6, Reposter Pubkey) instead of the Original Video's metadata to generate the comment filter descriptor. This causes valid comments (which tag the Original Video) to be filtered out by `isVideoCommentEvent`. Added: - `examples/reproducers/2-repost-comment-visibility-bug/reproduce_issue.js` - `examples/reproducers/2-repost-comment-visibility-bug/README.md`
30 lines
1.2 KiB
Markdown
30 lines
1.2 KiB
Markdown
# Repost Comment Visibility Bug
|
|
|
|
This reproducer demonstrates an issue where comments made on an original video are not visible when viewing that video via a Repost (Kind 6).
|
|
|
|
## The Bug
|
|
|
|
When viewing a repost, the application often passes the Repost event's metadata (Kind 6, Reposter Pubkey) along with the *Original Video's ID* to the comment system.
|
|
|
|
The `CommentThreadService` (via `normalizeCommentTarget`) creates a filter descriptor based on this input. It expects comments to tag the **Repost** (Kind 6) and the **Reposter**.
|
|
|
|
However, comments are almost always made on the **Original Video** (Kind 30078), tagging the **Original Author**.
|
|
|
|
Because `isVideoCommentEvent` enforces strict matching of `rootKind` and `rootAuthor` against the descriptor, it rejects the valid comments on the original video, resulting in an empty comment section.
|
|
|
|
## Running the Reproducer
|
|
|
|
```bash
|
|
node --import ./tests/test-helpers/setup-localstorage.mjs examples/reproducers/2-repost-comment-visibility-bug/reproduce_issue.js
|
|
```
|
|
|
|
## Expected Output (Failure)
|
|
|
|
```
|
|
Input Target: { ... videoKind: 6 ... }
|
|
Generated Descriptor: { ... rootKind: '6' ... }
|
|
...
|
|
Is Comment Visible? false
|
|
FAIL: Comment on original video is NOT visible when viewing repost.
|
|
```
|