Merge pull request #789 from PR0M3TH3AN/codex/add-lazy-initialization-guard-to-handle_toggle_quick_unlock

Initialize quick unlock config on demand
This commit is contained in:
thePR0M3TH3AN
2025-08-06 20:23:09 -04:00
committed by GitHub
3 changed files with 50 additions and 4 deletions

View File

@@ -819,8 +819,18 @@ def handle_toggle_quick_unlock(pm: PasswordManager) -> None:
"""Enable or disable Quick Unlock."""
cfg = pm.config_manager
if cfg is None:
print(colored("Configuration manager unavailable.", "red"))
return
vault = getattr(pm, "vault", None)
fingerprint_dir = getattr(pm, "fingerprint_dir", None)
if vault is not None and fingerprint_dir is not None:
try:
cfg = pm.config_manager = ConfigManager(vault, fingerprint_dir)
except Exception as exc:
logging.error(f"Failed to initialize ConfigManager: {exc}")
print(colored("Configuration manager unavailable.", "red"))
return
else:
print(colored("Configuration manager unavailable.", "red"))
return
try:
enabled = cfg.get_quick_unlock()
except Exception as exc:

View File

@@ -0,0 +1,28 @@
from pathlib import Path
from tempfile import TemporaryDirectory
from main import handle_toggle_quick_unlock
from seedpass.core.manager import PasswordManager
from helpers import create_vault, TEST_SEED, TEST_PASSWORD
from utils.fingerprint import generate_fingerprint
def test_toggle_quick_unlock_after_profile_creation(monkeypatch):
with TemporaryDirectory() as tmpdir:
tmp_path = Path(tmpdir)
monkeypatch.setattr(Path, "home", lambda: tmp_path)
vault, enc_mgr = create_vault(tmp_path, TEST_SEED, TEST_PASSWORD)
pm = PasswordManager.__new__(PasswordManager)
pm.vault = vault
pm.encryption_manager = enc_mgr
pm.fingerprint_dir = tmp_path
pm.current_fingerprint = generate_fingerprint(TEST_SEED)
pm.config_manager = None
inputs = iter(["y"])
monkeypatch.setattr("builtins.input", lambda *a: next(inputs))
handle_toggle_quick_unlock(pm)
assert pm.config_manager is not None
cfg = pm.config_manager.load_config(require_pin=False)
assert cfg["quick_unlock_enabled"] is True

View File

@@ -143,7 +143,11 @@ def test_vault_lock(monkeypatch):
pm.locked = True
pm = SimpleNamespace(
lock_vault=lock, locked=False, select_fingerprint=lambda fp: None
lock_vault=lock,
locked=False,
select_fingerprint=lambda fp: None,
fingerprint_dir="/does/not/matter",
start_background_sync=lambda: None,
)
monkeypatch.setattr(cli_common, "PasswordManager", lambda: pm)
result = runner.invoke(app, ["vault", "lock"])
@@ -160,7 +164,11 @@ def test_root_lock(monkeypatch):
pm.locked = True
pm = SimpleNamespace(
lock_vault=lock, locked=False, select_fingerprint=lambda fp: None
lock_vault=lock,
locked=False,
select_fingerprint=lambda fp: None,
fingerprint_dir="/does/not/matter",
start_background_sync=lambda: None,
)
monkeypatch.setattr(cli_common, "PasswordManager", lambda: pm)
result = runner.invoke(app, ["lock"])